Use advised naming - Githubissues

fog / fog-vsphere

Fog for vSphere

MIT License

36 stars 63 forks source link

Use advised naming #192

Closed ezr-ondrej closed 5 years ago

ezr-ondrej commented 5 years ago

Namespacing prefered according to https://github.com/fog/fog-core/blob/master/spec/compute_spec.rb

After few necessary changes in foreman i tested:

List VMs
Delete VM
Power On VM (power off doesnt work in my ESXi for some reason so untested).
Create VM

ezr-ondrej commented 5 years ago

Reverted the alias. That case, we should put it in README probably, for fast debugging.

timogoebel commented 5 years ago

Yeah, we should update the README with what changed in 3.0.0. :-)

ezr-ondrej commented 5 years ago

Should I do that, or we will do that in follow-up (bumb PR)?

timogoebel commented 5 years ago

@ezr-ondrej: It can't hurt to add that now. :-)

ezr-ondrej commented 5 years ago

@chris1984 It would be perfect, but I guess it doesn't make sence to run them on foreman since this is going to break foreman for sure after bump, could I ping you on a PR in foreman, once this is merged for the tests, please?

timogoebel commented 5 years ago

Thanks a bunch, @ezr-ondrej!