search

fog / fog-vsphere

Fog for vSphere
MIT License
36 stars 63 forks source link

Eager zero fixes #252

Closed sbernhard closed 4 years ago

chris1984 commented 4 years ago

@sbernhard will start to test on Satellite and Foreman

sbernhard commented 4 years ago

still not done. eager_zero will now be returned from fog to foreman but foreman expects eagerzero and fog sends eager_zero :(

sbernhard commented 4 years ago

how can I fix these 2 codeclimate issues?

timogoebel commented 4 years ago

how can I fix these 2 codeclimate issues?

Definitely not in the scope of this PR.

sbernhard commented 4 years ago

Ah, right. It would be good that the UI (= foreman) validates, that a disk can not be set to thin and eager_zero together.

ezr-ondrej commented 4 years ago

Ah, right. It would be good that the UI (= foreman) validates, that a disk can not be set to thin and eager_zero together.

Will do in the takeover PR :+1:

ezr-ondrej commented 4 years ago

I've get that safeguard in the foreman PR, can we get that in this PR anyway so it's safe for other users as well?

ezr-ondrej commented 4 years ago

Thanks @sbernhard !