search

fog / fog-vsphere

Fog for vSphere
MIT License
35 stars 62 forks source link

Fix resource pool creation with '/' in name #261 #262

Closed rlazoryshchak closed 3 years ago

rlazoryshchak commented 3 years ago

Now we can create resource pool with '/' in resource pool and root resource pool namespace.

rlazoryshchak commented 3 years ago

@ezr-ondrej and @chris1984 could you take a look?

ezr-ondrej commented 3 years ago

@rlazoryshchak could you add a comment why do we need the transpolation of /, please? Apart of it :+1:

rlazoryshchak commented 3 years ago

This is fix naming of resource pools which contains '/' symbol. Bug coused by rbvmomi transpolation '/' to '%2f' and while creating nested resource pool we can't find it in parent resource pool which contains '/'.

ezr-ondrej commented 3 years ago

I've added the comment in the commit comment to be easily found in the future, thanks @rlazoryshchak :+1: