Fixes #272 - New NIC ID decrements from initial random int to avoid collisions

fog / fog-vsphere

Fog for vSphere

MIT License

36 stars 63 forks source link

Fixes #272 - New NIC ID decrements from initial random int to avoid collisions #275

Closed phess closed 2 years ago

phess commented 2 years ago

After some discussion at https://github.com/fog/fog-vsphere/pull/273 (merged), the code to generate a new NIC ID will now generate a new random base ID once for each new VM, deriving new NIC IDs from this base by decrementing it for each new NIC.

E.g. for a new VM the new random base ID may be -26789. The first NIC will have NIC ID=-26790. Second NIC will have NIC ID=-26791. ...and so on.

Ron-Lavi commented 2 years ago

@chris1984 Hi, any chance that you could take a look at this one?

chris1984 commented 2 years ago

@Ron-Lavi yeah I will take a look today.