search

fog / fog-vsphere

Fog for vSphere
MIT License
36 stars 63 forks source link

Add disk and partitions info #284

Closed sbernhard closed 1 year ago

chris1984 commented 1 year ago

@sbernhard i'll start to review this

sbernhard commented 1 year ago

Thanks @chris1984 Unfortunately, I don't know if the failed tests are related to this change. Finally, I want to add the information of disk/partitions to TheForeman.

chris1984 commented 1 year ago

Looks like the tests are failing because of the PR. I will pull it down and work on a patch for you.

sbernhard commented 1 year ago

Looks like the tests are failing because of the PR. I will pull it down and work on a patch for you.

You are right. I think the VCR cassettes needs to be updated. Unfortunately, I have no clue how.

chris1984 commented 1 year ago

I think I figured out how to rerecord them, I am just going to merge this and will make a seperate pr to fix the tests then make a new release for you.