search

fog / fog-vsphere

Fog for vSphere
MIT License
35 stars 62 forks source link

Version in tag 3.6.2 is 3.6.1 instead of 3.6.2 #289

Closed nadjaheitmann closed 5 months ago

nadjaheitmann commented 6 months ago

See here https://github.com/fog/fog-vsphere/blob/v3.6.2/lib/fog/vsphere/version.rb

nadjaheitmann commented 6 months ago

And tag 3.6.1 should be called v3.6.1 to be in line with the other tags :)

nadjaheitmann commented 6 months ago

Well, it looks like the newest version is 3.6.1 but in foreman-packaging, there is a reference to 3.6.2 . Can someone help me out here?

https://github.com/theforeman/foreman-packaging/blob/rpm/develop/packages/foreman/rubygem-fog-vsphere/rubygem-fog-vsphere.spec

chris1984 commented 6 months ago

I will start to take a look

micwoj92 commented 5 months ago

@nadjaheitmann this is because 3.6.1 was broken on rubygems https://github.com/fog/fog-vsphere/issues/286

It was removed, 3.6.2 was uploaded and I guess that Chris just forgot to update ver before pushing.

Anyway I guess this is now "solved" due to 3.6.3 release.

chris1984 commented 5 months ago

Yeah, sorry about not coming back to this, 3.6.3 is released on rubygems.org and if you use fog-vsphere in Foreman, it has been introduced into the nightly repos. I broke the version when I bumped it last time, multitasking failed on my part.

nadjaheitmann commented 5 months ago

Thanks @chris1984

Do you mind cherry-picking the commit to Foreman 3.9 such that it is also fixed there?

chris1984 commented 5 months ago

@nadjaheitmann just made the PR there:

https://github.com/theforeman/foreman-packaging/pull/10308