Add an exception for the missing storage field

fog / fog-vsphere

Fog for vSphere

MIT License

35 stars 62 forks source link

Add an exception for the missing storage field #294

Closed girijaasoni closed 3 months ago

girijaasoni commented 3 months ago

This is a proposed solution for #2186114 I think creating a host without mentioning the storage pod or the datastore should not be permitted. Adding validation is one way to go but achieving that is extremely difficult. Adding an exception is a much simpler approach to it.

I'm open for any other ideas to approach this problem. Please feel free to share your thoughts on this. cc: @shimshtein

ShimShtein commented 3 months ago

A bit of context: currently the system does not allow empty storage field, and fails the creation of a VM with "Invalid path" error, which is not indicative at all.

ShimShtein commented 3 months ago

LGTM code-wise.