search

fog / fog-vsphere

Fog for vSphere
MIT License
36 stars 63 forks source link

Explicitly list files and dirs included in gemspec (test_)files #299

Closed dosas closed 5 months ago

dosas commented 5 months ago

With the catch all approach there were a lot of files included that do not need to be in the gem. I.e. Jenkinsfile, all dot files and dirs related to CI configuration, and rubocop linting ...

This causes problems when i.e. building rpm packages where all of these files need to be explicitly excluded: see https://github.com/theforeman/foreman-packaging/blob/rpm/develop/packages/foreman/rubygem-fog-vsphere/rubygem-fog-vsphere.spec#L50

chris1984 commented 5 months ago

@dosas can you rebase this on the 2 pr's of yours I just merged, to see if the tests go green?

dosas commented 5 months ago

@dosas can you rebase this on the 2 pr's of yours I just merged, to see if the tests go green?

Done

dosas commented 5 months ago

@chris1984 I would like to add this approach to all fog-* repos, what do you think?

chris1984 commented 5 months ago

Contributor

Yeah I thnk this is a great idea, thanks for helping out here. I don't have merge access on the others, but I would think it would be accepted.

dosas commented 5 months ago

There is still a typo

dosas commented 5 months ago

There is still a typo

Fixed