Closed fernandes closed 9 years ago
@fernandes Can you address my comments about the old api breaking?
There are some cases where i broked the old api because it was doing too much and thus hard to unit test but i would like to keep compatibility where it is possible without too much efforts.
sure, I made a comment any point you addressed, if we think everything is ok, I send the commit fixing these API breaks and we move forward... ty
@fernandes Go ahead with coding. =)
@fernandes Could you address the @houndci comment as well?
Probably everything is fine right now ;)
@fernandes I just merged since the tests are already broken. We need to fix the nokogiri
installation in ruby 1.9.2. We need to change the gemfiles to be like these
Thanks for the contribution! Maybe we could look at adding specs to those requests as well. =)
oh... ty :wink:
is pretty much easier add tests once we have methods and are dealing with xenserver on daily basis, I'm gonna add more messages for another objects then I come back and add vcr tests for all these messages
Add messages keeping most similar to XenServer api, including parameters names
Some classes were forcing some parameters to XenServer, I just left them needing to be explicit passed, if we define its better assume some default values, no problem