search

fog / fog-xenserver

Module for the 'fog' gem to support XENSERVER
MIT License
16 stars 22 forks source link

Fix build #34

Closed fernandes closed 9 years ago

fernandes commented 9 years ago

build was :broken_heart: now is :heart: :heart_eyes:

fernandes commented 9 years ago

sorry about sending Pool messages commit here, just would like to ensure everything is ok at this point

fernandes commented 9 years ago 
ERROR (0:00:01.059) 0001 should create a new vif
          /home/travis/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/xmlrpc/client.rb:565:in `do_rpc': Wrong size. Was 11028, should be 11027
        @ lib/fog/xen_server/connection.rb:33:in `request'
          /home/travis/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/xmlrpc/client.rb:420:in `call2'
          /home/travis/.rvm/rubies/ruby-1.8.7-p374/lib/ruby/1.8/xmlrpc/client.rb:410:in `call'
          (eval):1:in `request'
          lib/fog/compute/xen_server/requests/get_record.rb:10:in `eval'
          lib/fog/xen_server/connection.rb:33:in `request'
          lib/fog/compute/xen_server/requests/get_record.rb:10:in `get_record_by_ref'
          lib/fog/compute/xen_server/requests/get_record.rb:6:in `get_record'
          lib/fog/collection.rb:11:in `get'
          lib/fog/collection.rb:20:in `get_by_name'
          spec/fog/compute/xen_server/requests/create_vif_spec.rb:19

@plribeiro3000 any idea here? on my machine is going fine

fernandes commented 9 years ago

make a new record for create_vif worked! :D

plribeiro3000 commented 9 years ago

@fernandes Can you take a look at the require 'turn' issue?

fernandes commented 9 years ago

:fireworks: build passed!!!! :fireworks:

plribeiro3000 commented 9 years ago

@fernandes :+1:

fernandes commented 9 years ago

@plribeiro3000 Any idea why ree sometimes goes green, sometimes fail?

plribeiro3000 commented 9 years ago

I'm looking into it right now.

fernandes commented 9 years ago

:+1:

plribeiro3000 commented 9 years ago

It just raised a custom exception i made: Clone Operation not Allowed in here.

It sounds like the VCR cassetes are returning a server that can't be cloned. I was having this error before. My guess is the spec is just wrong. Somehow i think fog doesn't return always at the same order so sometimes it might get a server without clone capabilities at last in the array.

I think we should let this for now and fix this bad spec in another pull request.

fernandes commented 9 years ago

yeah... weird it worked here: https://travis-ci.org/fog/fog-xenserver/builds/41872868

hahahah damm, I didn't got whats happening :stuck_out_tongue_winking_eye:

fernandes commented 9 years ago

what thinking, you said fog doesn't return always at the same order, but the cassete was recorded, so the order will be always the same :)

plribeiro3000 commented 9 years ago

@fernandes Yeah, vcr returns always the same order but for some reason we are not getting it at the same order in our spec. If you try locally you will see it. When i implemented this spec i checked this behavior of ramdoness. If i remember there was a server wihtout clone capabilities being returned and this were making the test fail conditionally.

Lets just wait for the output of your last commit and merge it! :+1: