Closed HashNotAdam closed 7 years ago
Awesome. Thanks @HashNotAdam.
Do you want to push it over again with your git settings fixed? Otherwise you gotta loose those commits. ðŸ˜
@plribeiro3000 shouldn't be any concern about losing anything; after one PR is merged, the other can be rebased.
I was talking about your the ownership of the code you just did. See this other comment in the other thread: https://github.com/fog/fog-xenserver/pull/64#issuecomment-282147428
Hmmm. After #64 got merged this have merge conflicts. Can you fix it please?
Thank you for all your help @plribeiro3000 — I've rebased
Thank you @HashNotAdam !
Thanks for fix.
@plribeiro3000 will you consider a new tag/release?
I'm travelling right now. Will do it later.
Em qua, 1 de mar de 2017 11:36, sleenen notifications@github.com escreveu:
Thanks for fix.
@plribeiro3000 https://github.com/plribeiro3000 will you consider a new tag/release?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fog/fog-xenserver/pull/65#issuecomment-283356486, or mute the thread https://github.com/notifications/unsubscribe-auth/AApEuCoVzMIGpcfCe4iLfCm_i_X9jOcWks5rhYJigaJpZM4MJhWN .
Ops. forgot about this. Will do asap.
Released as 0.3.0
cheers
Have gotten tired of waiting for PR #63 so I've patched it myself and have tested it against the full suite in PR #64 (however, this PR excludes those changes).
@plribeiro3000 makes an interesting point about the value of removing
symbolize_keys!
altogether, however, I felt that it would be best to push this out quickly and then take time to test for issues that arise from moving to string-based keys.