fog / fog-xenserver

Module for the 'fog' gem to support XENSERVER
MIT License
16 stars 22 forks source link

Fixnum deprecated in Ruby 2.4 #65

Closed HashNotAdam closed 7 years ago

HashNotAdam commented 7 years ago

Have gotten tired of waiting for PR #63 so I've patched it myself and have tested it against the full suite in PR #64 (however, this PR excludes those changes).

@plribeiro3000 makes an interesting point about the value of removing symbolize_keys! altogether, however, I felt that it would be best to push this out quickly and then take time to test for issues that arise from moving to string-based keys.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling c3178f5bcec5295ae9dca623f2356417ba714a1c on HashNotAdam:fix/fixnum_deprecated into on fog:master.

plribeiro3000 commented 7 years ago

Awesome. Thanks @HashNotAdam.

Do you want to push it over again with your git settings fixed? Otherwise you gotta loose those commits. 😭

HashNotAdam commented 7 years ago

@plribeiro3000 shouldn't be any concern about losing anything; after one PR is merged, the other can be rebased.

plribeiro3000 commented 7 years ago

I was talking about your the ownership of the code you just did. See this other comment in the other thread: https://github.com/fog/fog-xenserver/pull/64#issuecomment-282147428

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 24aea78c68ab42b0a6908c369130685efc276740 on HashNotAdam:fix/fixnum_deprecated into on fog:master.

plribeiro3000 commented 7 years ago

Hmmm. After #64 got merged this have merge conflicts. Can you fix it please?

HashNotAdam commented 7 years ago

Thank you for all your help @plribeiro3000 — I've rebased

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.078% when pulling a0a4e394559084e8f81e64cd3f6ed5cbeca26d10 on HashNotAdam:fix/fixnum_deprecated into 2a0ba1565b38a144350fd6c6f42c0b2b86a06e6c on fog:master.

plribeiro3000 commented 7 years ago

Thank you @HashNotAdam !

sleenen commented 7 years ago

Thanks for fix.

@plribeiro3000 will you consider a new tag/release?

plribeiro3000 commented 7 years ago

I'm travelling right now. Will do it later.

Em qua, 1 de mar de 2017 11:36, sleenen notifications@github.com escreveu:

Thanks for fix.

@plribeiro3000 https://github.com/plribeiro3000 will you consider a new tag/release?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fog/fog-xenserver/pull/65#issuecomment-283356486, or mute the thread https://github.com/notifications/unsubscribe-auth/AApEuCoVzMIGpcfCe4iLfCm_i_X9jOcWks5rhYJigaJpZM4MJhWN .

plribeiro3000 commented 7 years ago

Ops. forgot about this. Will do asap.

plribeiro3000 commented 7 years ago

Released as 0.3.0

sleenen commented 7 years ago

cheers