Closed zozoh94 closed 5 years ago
I created a new branch from master because the rebase was not simple with file renaming.
Hey @zozoh94. Thanks!
Whats the issue with the current approach where the lib does it automatically without the need of a configuration parameter?
The problem is in lib/fog/xenserver/compute/real.rb line 19 because it will raise an Exception when xenurl is slave. Inside connection.rb response["status"] will not be equal to "Success".
Can't we rescue the exception and keep it they way it is?
My concern is that since you can't do anything on a slave it does not make sense to have a parameter to force this. It should always connect to the master node automatically.
You're right ! Is it better like that ?
@zozoh94 LGTM except for some small details. I will happily bring this in once you fix them. 😄
Thanks for your efforts here @zozoh94
I made a PR few month ago and you merged it. But some new tests recently reveals that the process of finding master URL from slave doesn't work as I imagine. This is a new PR which works well.