fogfish / esq

simple persistent queues for Erlang
Apache License 2.0
56 stars 10 forks source link

Project is not longer compile with rebar. works only via rebar3 #11

Closed silviucpp closed 6 years ago

silviucpp commented 6 years ago

Lot of libraries still keeps compatibility. Build is broken because in rebar you can't set as deps like: datum without specifying the github url and tag.

Silviu

fogfish commented 6 years ago

It does not sounds good! Let me think what I can do. BTW, What is your motivation to use rebar?

silviucpp commented 6 years ago

Hello, Lot of ancient projects still uses rebar. You can see here: https://github.com/benoitc/hackney/blob/master/rebar.config.script on how other libraries handles this to keep compatible with both

fogfish commented 6 years ago

Yeah, I do see that some libraries keeps the compatibility. I am trying to understand your reason of still using rebar?

E.g. I've migrated to rebar3 few years ago. I do not think that any new development goes with old rebar?

silviucpp commented 6 years ago

Hello,

I have few ancient projects that are using NIFS which requires more work to migrate to rebar3, also they are using some old code for deployment that depends on rebar and last time when I tried to migrate I found this bug : https://github.com/erlware/relx/issues/511 :)) was marked as fixed but I see also commits in June this year on this bug even if I reported in 2016 :).

fogfish commented 6 years ago

I see, that you for clarification. This was my guess as well (about ancient projects). I'll bring the support for rebar but you would need to help me with testing. I would introduce this feature in separate branch first. Once, You'll confirm that it works I'll merge it to master.

I hope you are fine with this!

fogfish commented 6 years ago

Please test PR #12. I'll merge it once you confirm it.

silviucpp commented 6 years ago

Working fine