FOGL-3613 Remove read_key references from FogLAMP

foglamp / FogLAMP

An open source platform for the Internet of Things, it acts as an edge gateway between sensor devices and cloud storage systems

http://foglamp.readthedocs.io/

Apache License 2.0

70 stars 42 forks source link

FOGL-3613 Remove read_key references from FogLAMP #1814

Closed MarkRiddoch closed 4 years ago

MarkRiddoch commented 4 years ago

https://github.com/foglamp/FogLAMP/blob/2102e47a25a25de66e8c1e2806c9001841f24367/tests/unit/python/foglamp/services/core/api/test_support.py#L196

https://github.com/foglamp/FogLAMP/blob/2102e47a25a25de66e8c1e2806c9001841f24367/tests/unit/python/foglamp/services/core/api/test_support.py#L213

The instance in test_support are merely testing the parsing of syslog and are not related to readings so these will stay as arbitrary, random strings.

ashish-jabble commented 4 years ago

@MarkRiddoch PR tester check is failing with commit https://github.com/foglamp/FogLAMP/pull/1814/commits/3571d19567a6c470e21d79b43bfabe2a213511c5. And I do not think its worth to fix the tests, could you please delete the test file tests.unit.python.foglamp.services.south.test_ingest this is dead code & no longer used. For more info See FOGL-3258

MarkRiddoch commented 4 years ago

@MarkRiddoch PR tester check is failing with commit 3571d19. And I do not think its worth to fix the tests, could you please delete the test file tests.unit.python.foglamp.services.south.test_ingest this is dead code & no longer used. For more info See FOGL-3258

Bizarrely that unit test passes locally