search

foglcz / JSONRpc2

Generic JSON-RPC v2 implementation
Other
19 stars 10 forks source link

Landed all my changes #8

Closed scottchiefbaker closed 9 years ago

scottchiefbaker commented 10 years ago

I took a serious rebase and some hand-holding but I was able to land all my changes on to yours. Couple of things

  1. As part of the rebase I opted to NOT convert to tabs (I excluded that commit). I also added a Vim modeline at the bottom so other vim users will contribute the same way
  2. Line #128 and #129 of Server.php I changed slighly to reflect the error level of the calling script. Not 100% if that's what we want. I'm open for discussion on that.
  3. It passes all my internal tests

Take a look and let me know what you think.

scottchiefbaker commented 9 years ago

This is old an not appropriate anymore