search

fogleman / hmm

Heightmap meshing utility.
MIT License
571 stars 50 forks source link

cmake and compiler warnings #14

Open rtlprmft opened 3 years ago

rtlprmft commented 3 years ago

I suggest a (maybe simple) cmake file. This is a bit more modern and easier to maintain than a classical handwritten makefile and can more easily check for the existence of the dependencies. I also added what is required to create binary packages (.tar.gz and debian packages). Not really important, but also easy to do.

In addition, instead of turning off compiler warnings, I have fixed the warning and left out the compiler switch from cmake's input. These were mainly two warnings: comparison between signed and unsigned in loops (I replaced int with the correct size_t) and redeclaration of variable names in local context (I added an underscore before the local ones)

rtlprmft commented 3 years ago

Sorry, I forgot to mention that I also implemented the option to set a scale factor for the x/y output so that when creating lithophanes one can more easily scale a picture down or adapt the resolution of image pixels (usually 1:1) to the of the printer (usually != 1:1)