search

fogleman / primitive

Reproducing images with geometric primitives.
https://primitive.lol/
MIT License
12.34k stars 608 forks source link

fix mutating ellipse ry #77

Closed larryng closed 4 years ago

axe312ger commented 5 years ago

@larryng you have more details? Maybe before & after screenshots? :)

larryng commented 5 years ago

No time for screenshots unfortunately. But basically the height of the ellipse should be restricted to the height of the image, not the width of the image. With the way it is pre-patch, an ellipse could grow to be taller than the image.

Very tiny bug, but a bug nonetheless.

laurenceforshaw commented 4 years ago

I've looked over the code and can verify the bug and recommend merging this.