foglio1024 / tera-custom-cooldowns

TCC (Tera Custom Cooldowns) - modern style replacement for some of the TERA Online UI elements
MIT License
69 stars 20 forks source link

TCC does not remove UI Elements on Menma's #268

Closed derdotte closed 10 months ago

derdotte commented 2 years ago

Hello, i found out that TCC Version: 1.4.137 does not remove the flight gauge when enabling the custom gauge. This is on Menma's Tera with the build-in proxy.

derdotte commented 2 years ago

I took a minute to find out why this bug occurs in the code and, well, its simply been commentated out at line 55 in tcc-launcher.js it says

this.install = function (installer)
        {
            const tccSettingsPath = Path.join(__dirname, "../tcc-settings.json");
            let noSettings = false;
            if (!FS.existsSync(tccSettingsPath))
                noSettings = true;;

            if (noSettings)
            {
                // no settings, remove everything by default
                m.log("No settings found, installing all removers by default.");
                this.tryInstallRemover("S1UI_CharacterWindow.gpk", installer, "Character window");
                this.tryInstallRemover("S1UI_TargetInfo.gpk", installer, "Mob HP bar");
                this.tryInstallRemover("S1UI_GageBoss.gpk", installer, "Boss HP bar");
                this.tryInstallRemover("S1UI_Abnormality.gpk", installer, "Buff bar");
                this.tryInstallRemover("S1UI_PartyWindow.gpk", installer, "Party windows");
                this.tryInstallRemover("S1UI_PartyWindowRaidInfo.gpk", installer, "Raid windows");
                this.tryInstallRemover("S1UI_PartyBoard.gpk", installer, "LFG window");
                this.tryInstallRemover("S1UI_PartyBoardMemberInfo.gpk", installer, "LFG details info");
                this.tryInstallRemover("S1UI_Chat2.gpk", installer, "Chat");
                // installer.gpk('gpk/S1UI_ProgressBar.gpk');
                return;
            }

aswell as in line 95-99

            // if (settings.FlightGaugeWindowSettings.Enabled === true)
            // {
            //     installer.gpk('gpk/S1UI_ProgressBar.gpk');
            //     m.log("Installed S1UI_ProgressBar remover.");
            // }

i suppose this was done with reason. Probably the gpk doesnt work?

foglio1024 commented 2 years ago

Exactly, the gpk needs to be properly modded.

derdotte commented 2 years ago

I see, i do not have the know-how to mod gpk's sadly

foglio1024 commented 10 months ago

Fixed some commits ago