search

fogonwater / we-are-here

Technical overview, code and data sources for "We Are Here: An Atlas of Aotearoa".
MIT License
66 stars 5 forks source link

Add project dependencies #1

Open kinow opened 5 years ago

kinow commented 5 years ago

Thanks a ton for providing the book code material. Any chance to get the project dependencies in a requirements.txt or similar?

So unless we have a list of the dependencies and versions, it could be hard to reproduce some of what was created here I think. I started collecting the dependencies in a requirements.txt, but PYPI doesn't have a mapnik official project (see their readme file, or https://github.com/mapnik/python-mapnik/issues/3). I could install it from a tag, but I think they are not tagging every release (last tag 3.x, their setup.py seems to indicate they are on 4.x).

Thanks! Bruno

kinow commented 5 years ago

It actually looks like mapnik is the only dependency used that is not part of the Python standard lib? It might be much simpler now, maybe we just need the version or commit of mapnik used?

fogonwater commented 5 years ago

Totally. Adding a single requirements.txt is on today's list. The current situation are currently lots of smaller requirements files, which are a pain for anyone coming to the project afresh. (I did not include these in the github repo.)

The mapnik issue is trickier. On my end, it's the only code that is still Python 2.x. I'm going to try to find a good way to upgrade to 3.7+ and provide a frictionless way for people to install.

fogonwater commented 5 years ago

Added a requirements.txt file to project root. Still need to mention is in README.md and make sure everything's in there. It does not include approach for Mapnik — will have to deal when I have a bit more time (i.e. after Oct 9).

kinow commented 5 years ago

Thanks @fogonwater !

I've been reading some tickets on the mapnik python project, and it looks like it will be a bit complicated. Python 2, and several versions behind of mapnik 3 compatibility-wise. Though they seem to have enough users that would justify investing a bit more of time to either fix it or lower the barrier to get contributors to fix it (I have no idea where I would start to help them).

Let me know if you need any help, or if you have a branch with a version/change, I'd be happy to test it on my environment.

Thanks! Bruno

fogonwater commented 5 years ago

Awesome. Thanks heaps, Bruno. I'm travelling at moment for the book launch, but will be back on this from Thursday. You're a champion!