Open mapix opened 4 months ago
@fohrloop Please help confirm if these preparations are sufficient for releasing the next version. If anything else is needed, please list it. Since it might be better to update the specific version number at the time of release, I have not updated the version number.
Hi @mapix and thank you for creating the PR!
I think the description of this PR has a mistake as this does not fix issue 111 or issue 133, but updates the changelog. There's another file change in tests/test_uploading_same_file_twice_with_errors.py
which skips a test to make the tests work on linux/macos. Could you please split the PR into two as it's addressing two things?
[dev]
extras. I think the fix should be changing this line in the setup.py: install_requires=["dash>=1.1.0", "packaging>= 21.0"],
to
install_requires=["dash>=1.1.0", "packaging>22"],
if a fix is provided, let's put that also through a separate PR (one PR per a thing).
Hey @mapix , just checking with you, have you seen the @fohrloop feedback?
I'm really hoping for the next dash-uploader release, specially due to the packaging
version requirement.
@fohrloop
Thanks for your advice. I missed this PR as I'm recently between jobs. I have followed your advice and separated all sub-PRs. Except for the packaging version, which I tested with 21.0 that everything works on the current codebase.
@mapix thanks a lot! I think we can keep this PR open until all the changes coming to the next releases are merged, and then have a final touch on the changelog.
Do you think it would make sense to update some of the JS packages before the release? My npm audit
shows:
39 vulnerabilities (8 moderate, 25 high, 6 critical)
which looks a bit worrying to me. Or what do you think? There's also quite a list of outdated JS packages shown by npm outdated
. What's your JS skill level?
For better code quality, it's advisable to fix the tests before merging this PR:
Also, ensure that development dependencies remain consistent with the release environment: