search

fohrloop / dash-uploader

The alternative upload component for python Dash applications.
MIT License
141 stars 29 forks source link

Skip the uploadtwice02 test on non-Windows systems #136

Closed mapix closed 4 weeks ago

mapix commented 1 month ago

Since os.unlink() is non-blocking on Linux and macOS, uploadtwice02 may hinder contributions from developers on non-Windows platforms.

fohrloop commented 4 weeks ago

Would it make more sense to fix the test instead of skipping it? There must be a reason the test_uploadtwice02_upload_a_file_twice_with_error exists in the first place. I did not understand the os.unlink() reference. Did you mean that reserve_file_for_while does not reserve the file on linux? Or something else?

And I fully support making contributions easier. As I just commented on the another PR, I feel that setting up the dev env is a bit difficult. If we can make the instructions easier to follow, that would be great!

Edit: I see you've also mentioned this issue on your previous PR ( https://github.com/fohrloop/dash-uploader/pull/130 )

fohrloop commented 4 weeks ago

Hi @mapix , I took another look. Now I see why there was such a test in the first place. I did some changes and pushed them to a separate PR https://github.com/fohrloop/dash-uploader/pull/140. Closing this one.