search

fohrloop / dash-uploader

The alternative upload component for python Dash applications.
MIT License
144 stars 30 forks source link

Refactored By creating new components #26

Closed Vipulsh closed 3 years ago

Vipulsh commented 3 years ago

Created some new components and replaced them with the code in Upload_ReactComponent.react.js. Please feel free to suggest more refactoring if required. Also I didn't setup the python environment , as I was only making the changes with React.

fohrloop commented 3 years ago

I merged these to another branch: https://github.com/np-8/dash-uploader/tree/refactor_upload

I also continued the refactoring by merging all of the Button components (Cancel, Start, Pause) into one Button component, and tried to tidy the code a bit. There is still room for improvement but it looks much nicer now :)

fohrloop commented 3 years ago

Actually, planning to publish these all in the next (0.5.0) release, so merged to: https://github.com/np-8/dash-uploader/tree/0.5.0

Vipulsh commented 3 years ago

@np-8 Thanks for reviewing and merging it. I would like to contribute more to this project. Let me know if I can connect with you or anything that you would like me to work on.