search

fohrloop / dash-uploader

The alternative upload component for python Dash applications.
MIT License
144 stars 30 forks source link

Support the option "chunk_size" for "du.Upload". #38

Closed cainmagi closed 3 years ago

cainmagi commented 3 years ago
  1. Add an option chunk_size to du.Upload. It just simply exposes the chunkSize option of the react component.
  2. Extend the documentation of du.Upload and the changelog.
  3. Fix some typos in the documentation.

To author:

  1. I have not updated the documentation. If you think this PR is acceptable, I could add a commit for the docs before you merge it.
  2. Please blacklify upload.py from your side. Thank you!
fohrloop commented 3 years ago

Thanks for the PR @cainmagi ! I think this is perfectly fine! Yeah, it would perhaps good to include the parameter in the docs before merging (and add comment to changelog). As for the blackification, I'm just going to make a separate commit after the PR merge, and it's fine in this small sized PRs. On larger PRs it would be good to have the same style applied before accepting the PR.

By the way, what code editor you use? At least on Visual Studio Code there is support for automatic formatting (with black or others) on file save, which can be also configured just for one Workspace (handy!).

cainmagi commented 3 years ago

OK, I will implement the docs for this PR first.

I am using VS codes. But I have not tried automatic formatting before. I always use flake8 and pylint to check my codes and fix the warnings manually. In the last week, I have learned how to use black from you.

cainmagi commented 3 years ago

The documentation and changelog have been added.

fohrloop commented 3 years ago

Thanks again @cainmagi , this is now part of the dev branch and will be part of next release of dash-uploader!

cainmagi commented 3 years ago

Thank you! I have just changed 0.6.0 to TBD in the CHANGELOG. There should be another 0.6.0 in the docs that need to be changed (if you want to change it).

fohrloop commented 3 years ago

Oh yeah I see it in the chunk_size parameter description. I guess the next release will be 0.6.0 as there are new feature(s) coming, so most probably the version number will be correct. Have to update it later if not.