Open cainmagi opened 3 years ago
Thanks for posting the issue. If I understand correctly the documentation of resumable.js, the testChunks
must be set on, and there should be handling of these test chunks implemented in the server side.
From src/lib/components/Upload_ReactComponent.react.js you can see that the testChunks
are hard-coded to be disabled. Perhaps this has been an speed optimization thing for the original author, or the server side implementation just was not finished.
I guess I would not be implementing this in the near future as I have other projects that have higher priority, and right now I do not have need for the resumability. That being said, I can accept a PR fixing this and offer some help.
So, what would need to be done is to add some new parameter to du.Upload
, like resumable=True
, which would be then propagated to the underlying React component as testChunks=True
(to this line of Upload_ReactComponent.react.js). I would also change the testMethod
to 'GET'
as this is the default.
Then, probably the server side checking the test chunks might need some corrections. They are in the _get() method of the HttpRequestHandler.
Is this related to these messages when uploading multile files?
INFO:werkzeug:127.0.0.1 - - [15/Sep/2021 10:38:33] "POST /API/resumable?resumableChunkNumber=1&resumableChunkSize=1048576&resumableCurrentChunkSize=1048576&resumableTotalSize=14043146&resumableType=&resumableIdentifier=14043146-EC_B1mzXML&resumableFilename=EC_B1.mzXML&resumableRelativePath=EC_B1.mzXML&resumableTotalChunks=13&upload_id=4e49f94a-1643-11ec-923b-107b44934408 HTTP/1.1" 405 -
Hi @sorenwacker, I am not entirely sure what you are asking. Could you clarify your question?
I am getting this messages when uploading multiple files. I wonder if this is the same issue or something new.
not important.
Although
dash-uploader
is based onresumablejs
, it seems that the uploader could not resume from the interrupted uploading file (even we set the sameupload_id
). To reproduce the experiment, we could:upload_id
set to a specific value (or not used).I wonder whether the author is interested in implementing the resumable feature in the future. In my understanding, this implementation may be tricky, but I do not need this feature urgently.