search

fohrloop / dash-uploader

The alternative upload component for python Dash applications.
MIT License
141 stars 29 forks source link

Handle when no iscomplete correctly in callback #54

Closed hansharhoff closed 2 years ago

hansharhoff commented 2 years ago

When not iscomplete occurs in the callback the current implementation returns None which generates server side error in user console. Instead we can raise PreventUpdate() to suppress this issue.

I also added some instructions to Contributing that would help newcomers get to an installed package quicker. Added packaging to requirements as this is needed to import dash_uploader.

fohrloop commented 2 years ago

Hi! Thanks for the PR! I will look at it during the coming days! :) Does this PreventUpdate exist in all supported dash versions?

fohrloop commented 2 years ago

Hi! Thanks for the PR! I will look at it during the coming days! :) Does this PreventUpdate exist in all supported dash versions?

I checked this and the PreventUpdate exists in dash 1.1.0, at least.

fohrloop commented 2 years ago

This would be ready to be merged once the packaging requirements is moved from requirements.txt to setup.py.

hansharhoff commented 2 years ago

Yes, done

fohrloop commented 2 years ago

Great! Thank you!