fohtla / Fallout3Terminal

A recreation of the Fallout 3 terminal via a linux bash script! Requires cool-retro-term, sox and pv installed as packages.
MIT License
259 stars 17 forks source link

Use shebangs the recommended way. #1

Closed ericonr closed 4 years ago

ericonr commented 4 years ago

You should probably use the shebang (that first line on the file, which tells the operating system how to execute the file) as

#!/usr/bin/env bash

This way, anyone who uses your script but for some reason stores their preferred version of bash somewhere else, can still run it with their preferred version.

ericonr commented 4 years ago

All that said, awesome project!

longhorn09 commented 4 years ago

And maybe rename terminalscript to terminalscript.sh is kind of standard, to denote shell script.