foivz / pop-app-flutter

Mobile application for the course Entrepreneurial venture.
2 stars 0 forks source link

Improve post-merge situation #34

Closed mislavmatijevic closed 1 year ago

mislavmatijevic commented 1 year ago

After merging of #11 and #9 (17eff3d) into main, a lot of errors were introduced because both branches included changes to the project files structure. Some of these errors were fixed directly on main, but others are to be solved in the frame of this issue.

mislavmatijevic commented 1 year ago

@jfletcher20 If you catch some time tommorow, this is how far I've come. I'll try to work on this some more later tommorow.

jfletcher20 commented 1 year ago

Changelog

Important ⏫

  • [ ] item_card.dart -> changeAmount should also invoke onAmountChange's code

I don't understand what you mean by this - or what you intend, rather. IT seems to work fine for purposes of adding products to a package, at least. Should it also check if the store has that many products in stock, though, to limit adding only the amount that's in stock, or is the amount in stock at the moment of package creation irrelevant and only comes into play when creating a sale?

  • [x] ~ProductCounterCard not being displayed.~

I crossed out this task since ProductCounterCard has been deleted

Insignificant ⏬

  • [x] Refresh products and packages after a CRUD operation.
  • [x] Fix editing of a product -> currently it shows the wrong quantity

When the user edits a product, the tab refreshes - but the context menu for editing/deleting remains up, retaining the old product information. This means that if you update the name of example product "Keybrd" to "Keyboard", submit changes, then press edit again, the textcontrollers autofill with "Keybrd" instead of "Keyboard". This bug is very insignificant and should be the least of our priorities. (The bug does NOT appear when editing packages, so that's good.)

mislavmatijevic commented 1 year ago

@jfletcher20 Application works pretty good now. Still, some errors persist.

mislavmatijevic commented 1 year ago

Merged with main.

mislavmatijevic commented 1 year ago

There are still things left to be fixed before production (and hopefully after)!

mislavmatijevic commented 1 year ago

I think we can agree, post-merge apocalypse is over. Back to maintaining.