fokoid / grouptodo

Group todo list app created as part of the Google Developer Scholarship 2017
MIT License
2 stars 1 forks source link

Implement React hot loading #5

Closed fokoid closed 6 years ago

fokoid commented 6 years ago

As suggested by @muyaszed in #1. For more about hot loading see the React hot loader documentation.

muyaszed commented 6 years ago

Hi, I would like to put a note on what is being done here. Basically there are 2 item that were installed and configured.

  1. Webpack Hot Module replacement(HMR)
  1. React Hot Loader

The branch is ready for review and merge to the master #9

fokoid commented 6 years ago

So as I understand it the hot loader allows preserving React state between updates. But is this for production as well or just during development?

I guess point 1 is just for development. If so, should we continue to use the old build process during production?

muyaszed commented 6 years ago

Yes, basically that is what it is and it is for development only. As for the build process I am not very sure on how react is build during production, let say using heroku for example. anyways, i think it should be fine if the old process is used.

fokoid commented 6 years ago

Fixed with #9.