search

folbert / fewbricks

Write code to create ACF field groups, fields and re-usable modules.
https://fewbricks2.folbert.com
GNU General Public License v3.0
124 stars 12 forks source link

Composer autoload for bricks and layouts #22

Closed mindfullsilence closed 5 years ago

mindfullsilence commented 7 years ago

First, this codebase is absolute amazing. I pulled up the demo and BAM...just works.

Noticed you were using your own spl loader for the [theme]/fewbricks/[file] loading. If this is already a composer package, why not use composer's autoloader?

folbert commented 7 years ago

Thank you for your kind words :) And also your suggestion.

I would have to say that the autoloader is a leftover from the pre-composer days of Fewbricks. But, since I also want to accomodate installs the old fashioned way, I believe that the autoload have to stay. Perhaps I can detect if Composer is in use and skip my autoloader if that's the case.

I will look into it when I get a chance.

folbert commented 5 years ago

Blast from the past. I wont add any new non-essential functionality to Fewbricks1 at this point since Fewbricks2 is in the works.