search

folbricht / desync

Alternative casync implementation
BSD 3-Clause "New" or "Revised" License
343 stars 44 forks source link

allow store to use http query params in requests #229

Open om26er opened 1 year ago

om26er commented 1 year ago

The chunk store does not pass http query params when downloading chunks, this means if a URL is protected desync won't be able to download and hence fail. This PR fixes that and I have verified the change actually does work with Cloudfront's presigned URLs

om26er commented 1 year ago

@folbricht what do you think about this ?

folbricht commented 1 year ago

This basically preserves any query parameters given in the store URL (for HTTP stores and index stores). This seems safe to do. Would you be able to add a section in the README.md describing how to use signed URLs with a simple example?

om26er commented 1 year ago

Sure, I will add something during the weekend