search

folbricht / routedns

DNS stub resolver, proxy and router with support for DoT, DoH, DoQ, and DTLS
BSD 3-Clause "New" or "Revised" License
476 stars 63 forks source link

Push version tags #390

Closed mikhirev closed 6 months ago

mikhirev commented 6 months ago

Hi!

As I see, new version numbers are generated by github actions. They are tagged but tags are not pushed to the github repo. Instead of this new branches are created for each new version.

I use routedns as a module in my projects. Go tracks module versions by tags and ignore branches, so I'm unable to obtain a new module version unless I specify a commit hash. Please push version tags to the repo. To avoid ref name conflicts, you have to use different names for version branches, e. g. without leadingv (are that branches really needed?).

folbricht commented 6 months ago

Oh, I hadn't realized that wasn't working. I think it may be fixed in https://github.com/folbricht/routedns/pull/391 Can you try now to see if it's working for you?

mikhirev commented 6 months ago

Yes, now it's working. Thanks!

folbricht commented 6 months ago

Thanks for bringing this up