folbricht / routedns

DNS stub resolver, proxy and router with support for DoT, DoH, DoQ, and DTLS
BSD 3-Clause "New" or "Revised" License
479 stars 63 forks source link

incompatibility issue with github.com/quic-go/quic-go v0.45.1 #396

Closed limbo127 closed 3 months ago

limbo127 commented 5 months ago

hello, with latest go-quick release we have an incompatibility issue github.com/quic-go/quic-go v0.45.1

github.com/folbricht/routedns

../../dohclient.go:343:9: cannot use &quicConnection{…} (value of type quicConnection) as quic.EarlyConnection value in return statement: quicConnection does not implement quic.EarlyConnection (wrong type for method NextConnection) have NextConnection() quic.Connection want NextConnection(context.Context) (quic.Connection, error)

cbuijs commented 5 months ago

Same here. Needed to downgrade (or not upgrade) to a previous version of quic-go (it still works with v0.43.1).

folbricht commented 5 months ago

I'm traveling this without access to a dev machine. But if anyone wants to try to make a PR for it I can approve it

cbuijs commented 5 months ago

@folbricht That sounds like "Sitting on the beach with a margarita" :-).

I might give it a shot later, but I suck at these kind of things :-)

folbricht commented 4 months ago

Can you try out the issue-396 branch? It compiles but I haven't fully tested it yet

cbuijs commented 4 months ago

Compile works indeed when including issue-396 branch. The resulting executable seems to be working just fine. Will run it for a while to see if somethings pops up.