search

foldfelis / DisplayStructure.jl

A renderable 1D and 2D character array.
MIT License
10 stars 1 forks source link

Allow drawing boardless panel? #29

Open YongHee-Kim opened 2 years ago

YongHee-Kim commented 2 years ago

Hello Thanks for nice package.

I've noticed that you already support borderless Rectangle but those option is not accessble from Panel

I've made this commit to pass kwargs to the Rectangle from the Panel https://github.com/YongHee-Kim/DisplayStructure.jl/commit/87a56dd00968486f0814121aec52da95323aa3c6

here is MWE

using DisplayStructure
DisplayStructure.Panel("TestPanel", [5,12],[1,1];background = '.', border = false) |> render

image

foldfelis commented 2 years ago

Hi @YongHee-Kim , thanks for the MWE. I was planning to implement something like rich but with more dynamicly features. But currently I am too busy to make any progress on this project. Do you have any interest to collaberate to this project?

YongHee-Kim commented 2 years ago

Yes I'm interested in contributing to your project. While I'm not sure my knowledge on CS is good enough to be helpful (I'm struggling to understand the basic data types like IOBuffer), I will do what I can if you would guide me with the code 😃

foldfelis commented 2 years ago

Please feel free to open a PR and tag me to review