foldynl / QLog

Amateur radio logbook software
GNU General Public License v3.0
143 stars 17 forks source link

Calls with VE, VA are coding as Amsterdam & St Paul Islands instead of Canada #253

Closed willcohen closed 11 months ago

willcohen commented 11 months ago

In my log book, my Canadian entries are repeatedly being looked up and resolving as the wrong country. Is there a database I should be replacing or editing accordingly

foldynl commented 11 months ago

Please, could you provide me more information?

1) is your report related to new QSO input or import QSO of QSO Detail (QSO double click)? 2) Please, could you provide me with an example of callsign(s) that is(are) incorrectly identified? 3) QLog version and platform

Is there a database I should be replacing or editing accordingly

QLog periodically downloads prefixes and countries (CTY.dat). There is an option to fix records already entered into the database via the QSO Detail Dialog (double click on the QSO). There is also the possibility to fix the records for mapping prefixes to country, but I would not recommend this because QLog updates these records regularly every 21 days.

The first thing is to identify the issue

willcohen commented 11 months ago

Thank you for the response!

And yes -- these came from importing an ADIF from WSJT-X (before I knew how to have QLog listen), using macOS QLog 0.29:

ADIF Export
<adif_ver:5>3.1.1
<created_timestamp:15>20231026 181756
<programid:6>WSJT-X
<programversion:5>2.6.1
<eoh>
<call:6>VE3XFD <gridsquare:4>EN82 <mode:3>FT8 <rst_sent:3>-15 <rst_rcvd:3>-13 <qso_date:8>20231026 <time_on:6>192800 <qso_date_off:8>20231026 <time_off:6>193146 <band:3>20m <freq:9>14.074860 <station_callsign:4>W1WK <my_gridsquare:6>FN42KG <eor>

Entries detected by listening to the WSJT-X server aren't having this issue.

Even when I manually adjust the value of the country by right clicking on the callbook to type in the correct country name, the double-clicked QSO Detail still reads as Amsterdam & St Paul Islands, though it is adjusted in the main window with a newly corrected flag:

Screenshot 2023-11-06 at 2 27 06 PM
foldynl commented 11 months ago

Many thanks for the example above.

where do you see this wrong country ? I can confirm the wrong behavior in the QSO Detail (the dialog you sent above). But otherwise I see Canada in the export ADI, Log Table etc.

Could you list everything where you can see the wrong value?

willcohen commented 11 months ago

Excellent question. It took me a minute to figure it out after you asked --

I made a new fake QSO to not mess up the existing entry:

ADIF Export
<adif_ver:5>3.1.1
<created_timestamp:15>20231026 181756
<programid:6>WSJT-X
<programversion:5>2.6.1
<eoh>
<call:6>VE3AAA <gridsquare:4>EN82 <mode:3>FT8 <rst_sent:3>-15 <rst_rcvd:3>-13 <qso_date:8>20231105 <time_on:6>192800 <qso_date_off:8>20231105 <time_off:6>193146 <band:3>20m <freq:9>14.074860 <station_callsign:4>W1WK <my_gridsquare:6>FN42KG <eor>

When I import that ADI in, it shows up correctly as Canada in the main log window, but then the double-clicked detail shows Amsterdam & St Paul. If, from that detail window, I then edit and change any other details on the entry, upon saving, it then saves it with the incorrect country. To be clear, when saving, it does note that the country and continent appear incorrect and puts it in yellow to me to confirm, which is enough of a workaround for me now that I know it's happening, but the user'll have to manually change the country every time they save to avoid the country being re-saved incorrectly.

Screenshot 2023-11-06 at 2 53 50 PM
foldynl commented 11 months ago

the good news is that I am able to replicate everything you described above. The bad news is that I still don't see what's causing the issue. Currently, it seems that this is an issue of QSO detail dialog only.

Quick workaround is

1) Do not modify QSO via the QSO Detail dialog 2) you can directly fix the values. Select all impacted values in the Log table, then the context menu for the Country column (click the right mouse button), select "Edit Value", change value to "Canada" and press enter. All selected records will be changed to the new value "Canada" as you can see below.

This procedure should not be used for common editing QSOs because it only checks a very small set of field dependencies.

fix

Otherwise, thanks for reporting the error.

willcohen commented 11 months ago

Thank you for diagnosing! And thank you for your work on this tool -- it is extremely helpful to have an active open-source cross-platform program that works on macOS and provides so much functionality.