search

foliant-docs / foliant

Comprehensive markdown-based documentation toolkit
https://foliant-docs.github.io/docs/
MIT License
158 stars 9 forks source link

Feature/fix unescape #42

Closed artlomov closed 6 years ago

artlomov commented 6 years ago

(1) I replaced safe_load with load because YAML tags such as !path, !slug, !!python/name do not work if safe_load is used.

(2) I fixed regex pattern in _unescape preprocessor. It made similar to https://github.com/foliant-docs/foliant/blob/develop/foliant/preprocessors/base.py#L71. Dots (.) in regex patterns are evil! Because of them, the processing of this file: http://paste.restr.im/53666/ never ends.

(3) I replaced CRLF with LF in most of files. Files in the tests/test_pre/references/crlf directory left unchanged.

codecov[bot] commented 6 years ago

Codecov Report

Merging #42 into develop will increase coverage by 0.06%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
+ Coverage    76.31%   76.38%   +0.06%     
===========================================
  Files           13       13              
  Lines          342      343       +1     
===========================================
+ Hits           261      262       +1     
  Misses          81       81
Impacted Files Coverage Δ
foliant/preprocessors/_unescape.py 100% <100%> (ø) :arrow_up:
foliant/config/base.py 100% <100%> (ø) :arrow_up:
foliant/config/include.py 44.44% <33.33%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 513f227...74309fb. Read the comment docs.