folio-org / folio-analytics

Community query repository for FOLIO analytics based on Metadb/LDP
Apache License 2.0
15 stars 30 forks source link

Update loans_renewal_dates.sql derived table for Metadb #855

Closed VandanaShah-Cornell closed 1 week ago

VandanaShah-Cornell commented 1 month ago

This PR closes issue#854

This is a revision of the loans_renewal_dates derived table in LDP. -- This uses the circulation_loan_history table for the data source; this table has been significantly changed since the derived table was originally created -- Changes to query: -- truncated the renewal date ("created date") to 'minutes' to eliminate renewals seconds apart, which are artifacts of system processes, not actual patron renewals. -- added the item hrid -- selected the loan status from the circulation_loans table, not the circulation_loan_history table (which always shows "Open" for renewals) -- removed the loan history id ("id") from Select statement, since including it would make it impossible group by loan_id and count renewals -- removed the "loan_renewal_count" field (selected from the circulation_loan_history table) to prevent misuse of the field in calculating total renewals over a date range.