search

foliojs / font-manager

A C++ module for Node.js providing access to the system font catalog.
MIT License
295 stars 100 forks source link

node 12.18.3 error #53

Open vincentwan100 opened 4 years ago

vincentwan100 commented 4 years ago

nodejs: 12 electron: 8.8.0

npm rebuild error: BooleanValue can never throw. Use Isolate version. [-Wdeprecated-declarations] return value.ToLocalChecked()->BooleanValue(Nan::GetCurrentContext

manu-st commented 3 years ago

See PR #46 for the solution.

AlexandreKilian commented 3 years ago

@manu-st sorry, what was the solution? THE PR you referred to was never merged, how did you fix it for you?

manu-st commented 3 years ago

@AlexandreKilian I fixed it by having my package.json file points to the git repository for the associated PR:

"font-manager": "https://github.com/q-lukasz/font-manager.git#issue-45--compile-error-mac-os-x--node-13-7",

until it is fixed upstream.