search

foliojs / fontkit

An advanced font engine for Node and the browser
1.46k stars 219 forks source link

update some dependencies to fix npm warnings (audit) [careful!] #190

Closed luanpotter closed 4 years ago

luanpotter commented 5 years ago

This updates some dependencies to the latest version. I fixed the test script to use the new mocha version and they are passing.

However, be careful. Please verify if everything is fine with the new dependencies, because stuff might break. I run the tests but that might not be enough.

The motive is to have updated dependencies and fix warnings on npm regarding some deprecation. It doesn't fix all but most.

One question I have, is that I see the packages brfs and browserify-optional are dependencies. Are they still relevant? Because it doesn't look like browserify is used anymore, it's not a dep. and there is no script using it. It seems babel is used now instead. So, could they be removed? That would fix the remaining warnings from npm audit.

kevinbror commented 5 years ago

Will this be merged soon? I'm looking to resolve the vulnerabilities mentioned: https://github.com/foliojs/pdfkit/issues/928