scottrippey commented 5 years ago

What

As a follow-up to https://github.com/foliojs/fontkit/pull/194, this PR enables a global fontkit.setDefaultLanguage(lang) method.
Fonts will use the global language property, unless you explicitly override it via font.setDefaultLanguage(lang)
If a font property isn't available in the given language, it will attempt to find a backup language to use. For example, it will look for defaultLanguage, then "en", then just whatever is first.
Additionally, unit tests were added for fontkit.setDefaultLanguage as well as font.setDefaultLanguage

scottrippey commented 5 years ago

FYI, I analyzed all the included fonts, and Amiri was the only font that included an alternate language ("ar" Arabic). Very glad to find this font to test with!

scottrippey commented 5 years ago

@devongovett I matured this defaultLanguage approach a lot, and added unit tests! What do you think?

scottrippey commented 5 years ago

Thanks @devongovett ! What's the next step to get this published?

devongovett commented 5 years ago

It is already published in v1.8.0! 😉

foliojs / fontkit

Set a global default language #195

What