Fix Noto font bug

[canda]

A little bit of context. While working with pdfkit we found this error. https://github.com/foliojs/pdfkit/issues/1106 We narrowed down the repro to fontkit with this little script

const fs = require('fs');
const notosans = require('fontkit').openSync('./NotoSansCJKsc-Bold.otf');
const subsetFor = (text, file) => {
  const run = notosans.layout(text);
  const subset = notosans.createSubset();
  run.glyphs.forEach((glyph) => subset.includeGlyph(glyph));
  subset.encodeStream().pipe(fs.createWriteStream(file));
};
subsetFor('间。楼', 'output.ttf');

With this script you can see that glyphs were missing on the subset font if you opened the font with something like fontforge

Regarding the logic behind this fix, when !used_fds[fd] was false, last items in topDict.FDArray and used_subrs weren't really the ones corresponding to the current fd. So we are saving a dictionary to find the real index were those values were stored.

What do you think about this fix?

[blikblum]

LGTM. The only thing i think is missing is a test. You can look at existing ones as a base

[canda]

🤙 Added a test to check this case @blikblum

[jordonbiondo]

@blikblum bump, we're forking fontkit and pdfkit for now so we can use this fix, any word on merge and release so pdfkit can be updated?

[blikblum]

I dont have rights to commit to fontkit, only pdfkit

[jichang]

@devongovett can help to merge this and release a new version ?

[calvin-oen]

we need this to support Noto

[liborm85]

@calvin-oen You can use up-to-date fork https://github.com/foliojs-fork/fontkit.