folke / lazy.nvim

💤 A modern plugin manager for Neovim
https://lazy.folke.io/
Apache License 2.0
14.5k stars 348 forks source link

bug: Reordering commits as part of an interactive rebase in lazygit integration does not work anymore #875

Closed joliebig closed 1 year ago

joliebig commented 1 year ago

Did you check docs and existing issues?

Neovim version (nvim -v)

0.9.1

Operating system/version

Windows 11

Describe the bug

I'm using nvim with lazy.nvim and lazygit using the default configuration (lazygit as floating terminal) inside WezTerm. As part my development process I'm creating many commits which I rebase at the end before merging. lazygit provides such an operation as part of its edit functionality. When trying to reorder commits via <ctrl>+j or <ctrl>+k the floating terminal with lazygit looses focus and I'm back in the nvim buffer with lazygit staying open.

I know it worked before, but I don't know when it changed. I didn't use this functionality of reordering often.

Steps To Reproduce

  1. Run nvim on a project with a git-history.
  2. <leader>gg to open lazygit.
  3. Go to the commits section (4).
  4. Select a commit at least two commits away from the current branches HEAD.
  5. Select the latest commit and press <ctrl>+j (to push the commit one down).

Expected Behavior

Reordering should work as specified for lazygit.

Repro

No response

folke commented 1 year ago

https://github.com/LazyVim/LazyVim/issues/905