search

folke / neoconf.nvim

💼 Neovim plugin to manage global and project-local settings
Apache License 2.0
715 stars 29 forks source link

feat: allow root_dir conflict resolution in config #41

Closed GuillaumeLagrange closed 3 months ago

GuillaumeLagrange commented 1 year ago

Hello,

First of all thank you for the plugin which is working wonderfully well and solves an immense pain of working with nvim in a vs code world.

While working in a Rust monorepo, my workspace root_dir is set to ${REPO_ROOT}/.cargo/workspace, while the root dir for some crates is ${REPO_ROOT}/path/to/crate.

If the path/to/crate is shorter than .cargo/workspace, neoconf resolves the root dir as .cargo/workspace since it is longer. This is not a desired behavior on my end, since the monorepo is very large and rust-analyzer commes with insane behavior on startup for large code base.

This PR aims to make the conflict resolution performed in neoconf/util.lua.

Don't hesitate to tear the code a new one, this is my first lua PR, and I find the code in this plugin quite complex :sweat_smile:

Cheers

github-actions[bot] commented 3 months ago

This PR is stale because it has been open 60 days with no activity.

folke commented 3 months ago

You can just override it now: https://github.com/folke/neoconf.nvim/commit/197c17af5716075c0dd44f66aab80e20e9689c0a