search

folke / neoconf.nvim

💼 Neovim plugin to manage global and project-local settings
Apache License 2.0
715 stars 29 forks source link

feature: field type has changed in lua_ls config #47

Closed pysan3 closed 3 months ago

pysan3 commented 11 months ago

Did you check the docs?

Is your feature request related to a problem? Please describe.

With a recent change in lua_ls (PRs listed below), the expected values for workspace.checkThirdParty has changed from a boolean to string enum.

Please update the schema to align with the latest changes. Please see # Describe the solution you'd like section for the explanation of the new values.

Sidenote:

Not related to the new schema but there seems to still be an issue with type conversion atm to keep backwards compatibility working.

Describe the solution you'd like

Change schema for lua_ls.

This lets you skip the "apply third party library to workspace configuration" prompt.

The value of Lua.workspace.checkThirdParty can now be one of:

Ask (ask every time; this is equivalent to true)
Apply (always apply third-party libraries and set the workspace
configuration)
ApplyInMemory (always apply third-party libraries but don't set the
workspace configuration)
Disable (don't ask and don't apply; this is equivalent to false)

Backwards compatibility with the old boolean configuration values is maintained; true is treated as Ask and false is treated as Disable.

Describe alternatives you've considered

None.

Additional context

No response

pysan3 commented 11 months ago

Thanks to this PR, it is now not a breaking change but the values have been extended. https://github.com/LuaLS/lua-language-server/pull/2409

The values this option can take is as follows.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

pysan3 commented 3 months ago

Is there any reason why this is not merged?

folke commented 3 months ago

@pysan3 because this is not a PR?

Either way, the types are generated based on the schema provided by LuaLS