search

folke / tokyonight.nvim

🏙 A clean, dark Neovim theme written in Lua, with support for lsp, treesitter and lots of plugins. Includes additional themes for Kitty, Alacritty, iTerm and Fish.
Apache License 2.0
6.38k stars 430 forks source link

[Question] Home for ports of this theme? #329

Closed thomascft closed 7 months ago

thomascft commented 1 year ago

I've been using Tokyo Night for a while now and have had interest in porting it to other applications I use. I'm wondering if you had any plans on creating an organization that could house ports? I've liked how Catppuccin has created a parent organization and let their community create ports for each application. If this isn't something you want to do, I'll work on it separately, but I'd thought I'd check before I pulled the trigger on anything.

adrian5 commented 7 months ago

It's been a year. I think this should really be done, just like aforementioned Catppuccin. The current approach of deriving ports via Lua template is over-engineered and not an effective tradeoff:

  1. The core theme palettes remain pretty static
  2. The Lua template creates a significant barrier for contributors
    • By far the biggest reason in my eyes, I'm sure many potential contributions bounce right off
    • There are legitimate open requests and PRs for improvement, some of the latter having template issues (2).
  3. Perfect is the enemy of good
    • With (2) out of the way, there'd be more, possibly lower quality ports, that are better than none and much easier to improve on by actual end-users.

I hope Folke considers creating a TokyoNight organization, or else those with interest in seeing that happen. It's a great theme and open source of course.

folke commented 7 months ago

What exactly is over-engineered or difficult to create an extra?

See the one for delta (or any other one) for example: https://github.com/folke/tokyonight.nvim/blob/main/lua/tokyonight/extra/delta.lua

adrian5 commented 7 months ago

Most application themes are simple YAML/TOML files or similar. Those that don't use (let alone develop for) Neovim are unlikely to dive into Lua and try to get a build running. I think you're underestimating that hurdle, coming from your perspective. Anyway, message received.