folke / tokyonight.nvim

🏙 A clean, dark Neovim theme written in Lua, with support for lsp, treesitter and lots of plugins. Includes additional themes for Kitty, Alacritty, iTerm and Fish.
Apache License 2.0
6.41k stars 431 forks source link

feature: Set the color for `vim.g.terminal_color_13` #634

Closed ksaito422 closed 1 month ago

ksaito422 commented 1 month ago

Did you check the docs?

Is your feature request related to a problem? Please describe.

Thank you for the wonderful plugin.

I am using glyph_palette.vim, but I am encountering the following error.

   Error  09:01:33 notify.error lazy.nvim Failed to source `~/.local/share/nvim/lazy/glyph-palette.vim/plugin/glyph_palette.vim`

vim/_editor.lua:0: VimEnter Autocommands for "*"..script nvim_exec2() called at VimEnter Autocommands for "*":0..~/.local/share/nvim/lazy/glyph-palette.vim/plugin/glyph_palette.vim[7]..function glyph_palette#defaults#highlight[4]..<lambda>2, line 1: Vim(call):E121: undefined variables: g:terminal_color_13

Describe the solution you'd like

https://github.com/folke/tokyonight.nvim/blob/817bb6ffff1b9ce72cdd45d9fcfa8c9cd1ad3839/lua/tokyonight/theme.lua#L55-L56

Could you add the color for vim.g.terminal_color_13 here?

Describe alternatives you've considered

I considered setting it manually.

vim.cmd([[
    let g:terminal_color_13 = '#000'
    colorscheme tokyonight-moon
]])

Additional context

If it's an issue with vim-glyph-palette rather than tokyonight.nvim, I'll move it there.

ksaito422 commented 1 month ago

The color schemes where the issue occurred are tokyonight-moon and tokyonight-storm.

kristijanhusak commented 1 month ago

I think this is a typo, 18 should actually be 13. There are only 0 - 15 terminal colors.

ksaito422 commented 1 month ago

Thanks.