search

folke / trouble.nvim

🚦 A pretty diagnostics, references, telescope results, quickfix and location list to help you solve all the trouble your code is causing.
Apache License 2.0
5.36k stars 175 forks source link

Add multiline diagnostic support #305

Closed MariaSolOs closed 1 year ago

MariaSolOs commented 1 year ago

Fixes #279, #268 and #11

A preview of how this looks:

image
folke commented 1 year ago

Thank you for this PR!

I'll look into it later today, but I think this potentially breaks actions and folds on the different lines. Maybe not though, need to check :)

MariaSolOs commented 1 year ago

Thank you for this PR!

I'll look into it later today, but I think this potentially breaks actions and folds on the different lines. Maybe not though, need to check :)

Thanks to you! There are a couple of design questions in #279 but we should definitely first make sure this doesn’t break anything.

eatgrass commented 1 year ago

@MariaSolOs @folke please check the screenshot. How about keeping the first line in the entry, it seems more consistent image

folke commented 1 year ago

I've made multiline configurable and changed the layout as @eatgrass suggested. Still have to check if multline possibly breaks something

folke commented 1 year ago

All seems to work as it should. Merged. Thank you!

Edit: made multiline the default

MariaSolOs commented 1 year ago

All seems to work as it should. Merged. Thank you!

Edit: made multiline the default

Thanks to you! I hope people like the new layout as much as I do ☺️

kting28 commented 1 year ago

Thanks @MariaSolOs