fix: add guards to check for deleted parent windows

folke / trouble.nvim

🚦 A pretty diagnostics, references, telescope results, quickfix and location list to help you solve all the trouble your code is causing.

Apache License 2.0

5.24k stars 178 forks source link

fix: add guards to check for deleted parent windows #348

Closed Anna-log7 closed 4 months ago

Anna-log7 commented 9 months ago

Fixes #284 and #253

The line moved on line 356 is to get rid of the error for Vim:E444: Cannot close last window, which will show up if the parent is invalid.

The added check on line 307 is to fix the error: E565: Not allowed to change text or change window which errors on line 309 when the parent is invalid.

Both cases can be reproduced by having 2 or more buffers open, opening Trouble, then using :bdelete to delete your current "parent" buffer

folke commented 4 months ago

Development on the main branch is EOL.

Trouble has been rewritten and will be merged in main soon.

This issue/feature either no longer exists or has been implemented on dev.

For more info, see https://github.com/folke/trouble.nvim/tree/dev

cxwx commented 4 months ago

Has this been merge to main branch yet?