folke / which-key.nvim

💥 Create key bindings that stick. WhichKey helps you remember your Neovim keymaps, by showing available keybindings in a popup as you type.
Apache License 2.0
5.38k stars 177 forks source link

feat(view): ensure it's above other floating windows #442

Closed LoneExile closed 1 year ago

LoneExile commented 1 year ago

Ensure the which-key window appears above other floating windows, such as the LSP diagnostics or terminal that floats. This improves visibility when using the which-key plugin.

LoneExile commented 1 year ago

Zindex should be a user configurable setting if it is added imho.

Sure thing! I agree that making the z-index user configurable would be a better approach. How about adding the z-index option within the 'window' table like this?

window = {
    border = "none",
    position = "bottom",
    margin = { 1, 0, 1, 0 },
    padding = { 1, 2, 1, 2 },
    winblend = 0,
    zindex = 1000 -- new user configurable option
},
folke commented 1 year ago

Great idea!

LoneExile commented 1 year ago

I've made the requested changes and updated the README.md and default config to include the user-configurable z-index setting. Please take a look and let me know if any further adjustments are needed. Thanks!

folke commented 1 year ago

merged. thanks!