search

folkehelseinstituttet / Fhi.Frontend.Demo

MIT License
2 stars 1 forks source link

Add a new diagram type navigation #529

Closed proand closed 2 months ago

proand commented 3 months ago

Add a new diagram type nav with support for more diagram types, with or without icon. The new nav should be based on an existing POC from #531

Acceptance Criteria Given:

  1. Issue #531 Closed
  2. That we have decided how the logic for more than one nav should be implemented

Then:

  1. Go to https://dev-designsystem.fhi.no/developer/components/highcharts#highcharts-all-inclusive
  2. Test that navigation works as expected
  3. Make sure the new nav looks like the sketches i Figma (see fig. 1 and 2 below)

Figure 1 Image

Figure 2 These states must be available in the menu, ie. both normal and split button must handle disabled state. Image

proand commented 3 months ago

PS. NavDiagramTypeGroup.excludeFromMenu will be deprecated. Only disabled is necessary according to the new design.

yleaxeman commented 2 months ago

@proand https://github.com/folkehelseinstituttet/Fhi.Frontend.Style/pull/379 https://github.com/folkehelseinstituttet/Fhi.Frontend.Demo/pull/548