search

folkehelseinstituttet / Fhi.Smittestopp.App

Smittestopp 2 mobile application
MIT License
84 stars 18 forks source link

Implement new Exposure Notification API #223

Closed huaracheguarache closed 3 years ago

huaracheguarache commented 3 years ago

As can be seen here and in Google's official documentation, Google has updated their underlying Exposure Notification API to provide improved risk calculation. I tried determining whether Smittestopp uses the improved API by searching for ExposureWindow in the repos of Folkehelseinstituttet, but I didn't get any hits, so it seems like the legacy API is in use. I admit that this is a rather naive way of trying to figure this out, and I might be wrong.

nc-kano commented 3 years ago

@huaracheguarache Thank you for the message. Yes, currently we are using the legacy mode as we are limited to Xamarin.ExposureNotifications solution. There is already a pull request in Xamarin repository with this feature so we hope it will be published soon.

huaracheguarache commented 3 years ago

Is it this one? In that case they're really dragging their feet given that it opened in August of last year.

pavshr commented 3 years ago

Xamarin team have implemented it, but due to specifics of the Exposure Notification app development, they cannot really test the changes themselves. Until it is tested they cannot merge it and release it as a stable Nuget package as I understand. We are currently prioritizing other tasks and do not have resources to test the implemented changes by Xamarin from a preview Nuget feed. Client is aware of this, so we will update the issue as soon as we get more info.

Frederik-S-N-dk commented 3 years ago

A solution proposal has been sent to FHI. Awaiting further decisions.

Frederik-S-N-dk commented 3 years ago

The new EN API has been planned to part of a release in the begging of April.

keiji commented 3 years ago

Congratulations on your migration!

I am a collaborator of COCOA(Contact-Confirming Application in Japan).

We are planning to migrate to new API with Xamarin.

And I have a question. Where can we get Xamarin.ExposureNotification.0.16.0-alpha ? Did you build this yourself?

https://github.com/folkehelseinstituttet/Fhi.Smittestopp.App/blob/dev-R3.0/NDB.Covid19/TempNugetFeed/Xamarin.ExposureNotification.0.16.0-alpha.nupkg

nc-kano commented 3 years ago

@keiji Hello. Thank you for kind words. Yes, we had built the package ourselves from sources.

keiji commented 3 years ago

@nc-kano Hi, thank you! Keep in touch.

Michael-Olesen commented 3 years ago

This issue has been released today in version 3.0 of the Smittestopp app.